Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BCF-2605 clean up Configs #10551

Merged
merged 7 commits into from
Sep 11, 2023
Merged

BCF-2605 clean up Configs #10551

merged 7 commits into from
Sep 11, 2023

Conversation

krehermann
Copy link
Contributor

@krehermann krehermann commented Sep 7, 2023 •
edited
Loading

Previous changes made the relayer 1:1 with a chain. However, it purposefully avoided changing configuration. This meant that the chains themselves were configured with an Configs object whose original intention was to configure a chain set.

This PR removes the redundant configuration and greatly simplifies the code

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

I see that you haven't updated any README files. Would it make sense to do so?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6113665315

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6114579439

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6114622471

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6114796505

@krehermann krehermann force-pushed the BCF-2605-cleanup-Configs-interface branch from 0daadcb to 1babe90 Compare September 7, 2023 21:11
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6114828335

@krehermann krehermann force-pushed the BCF-2605-cleanup-Configs-interface branch from 1babe90 to 451e034 Compare September 7, 2023 21:53
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6115125772

@krehermann krehermann marked this pull request as ready for review September 7, 2023 21:59
@krehermann krehermann changed the title unify chain type BCF-2605 clean up Configs Sep 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6115421077

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6122325661

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6123870012

@krehermann krehermann force-pushed the BCF-2605-cleanup-Configs-interface branch from 8a5e8b0 to 6ebe26a Compare September 8, 2023 16:20
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6124077875

@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 66.3% 66.3% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6124904323

@krehermann krehermann added this pull request to the merge queue Sep 8, 2023
@krehermann krehermann removed this pull request from the merge queue due to a manual request Sep 8, 2023
@krehermann krehermann added this pull request to the merge queue Sep 8, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 8, 2023
@krehermann krehermann added this pull request to the merge queue Sep 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 11, 2023
@krehermann krehermann added this pull request to the merge queue Sep 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 11, 2023
@krehermann krehermann added this pull request to the merge queue Sep 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 11, 2023
@krehermann krehermann added this pull request to the merge queue Sep 11, 2023
Merged via the queue into develop with commit 6c2c10d Sep 11, 2023
115 of 117 checks passed
@krehermann krehermann deleted the BCF-2605-cleanup-Configs-interface branch September 11, 2023 19:19
@snehaagni snehaagni mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmank88 jmank88 jmank88 approved these changes

@jkongie jkongie Awaiting requested review from jkongie

@archseer archseer Awaiting requested review from archseer

@cfal cfal Awaiting requested review from cfal

@samsondav samsondav Awaiting requested review from samsondav

@prashantkumar1982 prashantkumar1982 Awaiting requested review from prashantkumar1982

@cedric-cordenier cedric-cordenier Awaiting requested review from cedric-cordenier

@connorwstein connorwstein Awaiting requested review from connorwstein

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krehermann @jmank88