Bump relay => fec1da7953fc340889554d22cc73ec2981f6eda9 #10583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
|
Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6149609804 |
chainchad
previously approved these changes
Sep 11, 2023
|
Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6161181386 |
|
Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6161181521 |
samsondav
force-pushed
the
bump_relay_3e71ad83c4b6bca5615c12f8ce697cc9f220a645
branch
from
de46485
to
4985235
Compare
samsondav
force-pushed
the
bump_relay_3e71ad83c4b6bca5615c12f8ce697cc9f220a645
branch
from
db91dcc
to
389d0d6
Compare
samsondav
commented
Sep 12, 2023
| @@ -206,7 +206,7 @@ func (cs EVMConfigs) Nodes(chainID relay.ChainID) (ns []types.Node, err error) { | |||
| } | |||
| nodes := cs.nodes(chainID) | |||
| if nodes == nil { | |||
| err = fmt.Errorf("no nodes: chain %s: %w", &chainID, chains.ErrNotFound) | |||
| err = fmt.Errorf("no nodes: chain %q: %w", chainID, chains.ErrNotFound) | |||
There was a problem hiding this comment.
This was producing a warning locally
chainchad
reviewed
Sep 12, 2023
chainchad
changed the title
chainchad
approved these changes
Sep 12, 2023
ad0ll
approved these changes
Sep 12, 2023
jmank88
approved these changes
Sep 12, 2023
|
SonarQube Quality Gate
|
samsondav
deleted the
bump_relay_3e71ad83c4b6bca5615c12f8ce697cc9f220a645
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.