Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Cosmos FeeToken to GasToken #10595

Merged
merged 4 commits into from
Sep 13, 2023
Merged

Conversation

calvwang9
Copy link
Contributor

@calvwang9 calvwang9 commented Sep 12, 2023

https://smartcontract-it.atlassian.net/browse/BCI-1931

Renaming the Cosmos config variable FeeToken to GasToken due to concerns about overloading the term when referring to the Chainlink node fees (paid in LINK).

TODO: change chainlink-cosmos import when smartcontractkit/chainlink-cosmos#373 is merged

@github-actions
Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

@github-actions
Copy link
Contributor

@calvwang9 calvwang9 marked this pull request as ready for review September 13, 2023 03:32
@jmank88 jmank88 added this pull request to the merge queue Sep 13, 2023
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 57.1% 57.1% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 13, 2023
@krehermann krehermann added this pull request to the merge queue Sep 13, 2023
Merged via the queue into develop with commit bfcbb31 Sep 13, 2023
97 of 98 checks passed
@krehermann krehermann deleted the BCI-1931/rename-feetoken branch September 13, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants