BCF-2368: ensure unique name per LOOPP #9762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
End to end work uncovered a problem where a plugin would not start because the prom server couldn't get a port. Ultimately this was caused by duplicate names in the LoopRegistry. This change makes names unique and, to ensure better error handling, it changes the Register function to error if called more than once. The latter change will make the problem much more clear should it ever happen again.
|
I see that you haven't updated any README files. Would it make sense to do so? |
jmank88
approved these changes
Jul 10, 2023
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End to end work uncovered a problem where a plugin would not start because the prom server couldn't get a port. Ultimately this was caused by duplicate names in the LoopRegistry.
This change makes names unique and, to ensure better error handling, it changes the Register function to error if called more than once. The latter change will make the problem much more clear should it ever happen again.