Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automation Telemetry: Send BlockNumber and Node Version #9927

Merged
merged 49 commits into from
Nov 17, 2023
Merged

Automation Telemetry: Send BlockNumber and Node Version #9927

merged 49 commits into from
Nov 17, 2023

Conversation

JonWong203
Copy link
Contributor

@JonWong203 JonWong203 commented Jul 25, 2023 •
edited by infiloop2
Loading

AUTO-6522

@github-actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@JonWong203 JonWong203 marked this pull request as ready for review August 1, 2023 16:44
@JonWong203 JonWong203 requested review from a team, jmank88 and krehermann as code owners August 1, 2023 16:44
@JonWong203 JonWong203 dismissed infiloop2’s stale review November 17, 2023 17:32

metrics are as expected

@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 48.7% 48.7% Coverage on New Code (is less than 75%)
Failed condition 45.8% 45.82% Duplicated Lines (%) on New Code (is greater than 3%)

See analysis details on SonarQube

@JonWong203 JonWong203 added this pull request to the merge queue Nov 17, 2023
Merged via the queue into develop with commit b2c1a17 Nov 17, 2023
87 checks passed
@JonWong203 JonWong203 deleted the auto-2.0-send-custom-telem branch November 17, 2023 19:37
@infiloop2 infiloop2 mentioned this pull request Dec 1, 2023
Merged
@snehaagni snehaagni mentioned this pull request Jan 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmalec cmalec cmalec left review comments

@anirudhwarrier anirudhwarrier anirudhwarrier left review comments

@infiloop2 infiloop2 infiloop2 left review comments

@amirylm amirylm amirylm left review comments

@FelixFan1992 FelixFan1992 FelixFan1992 approved these changes

@se3000 se3000 Awaiting requested review from se3000

@connorwstein connorwstein Awaiting requested review from connorwstein

@RensR RensR Awaiting requested review from RensR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@JonWong203 @RensR @cmalec @anirudhwarrier @FelixFan1992 @infiloop2 @amirylm