Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a doc that has the solidity style guide + the Chainlink style guide #13

Open
PatrickAlphaC opened this issue May 24, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@PatrickAlphaC
Copy link
Contributor

Describe the enhancement

Make a PR to the chainlink github with the style guide officially laid out.

@PatrickAlphaC PatrickAlphaC added the enhancement New feature or request label May 24, 2022
@joonakauranen
Copy link

joonakauranen commented Jun 21, 2022

How's this #434 ? Let me know if that needs some improvements or if you were thinking of something different altogether.

Also let me know if it's better I make a new PR since #434 is a bit of a mess. It has multiple commits cause I kept fixing the formatting. And it also has a typo fix for README.md

@krakxn
Copy link
Contributor

krakxn commented Jul 6, 2022

Does this still have to be done? If so, where in Chainlink's GitHub should the PR be made? Cheers.

@PatrickAlphaC
Copy link
Contributor Author

Probably the chainlink core repo.

https://github.com/smartcontractkit/chainlink

I'd like someone from the Chainlink Labs org to do it though, to make sure the style is correct.

@krakxn
Copy link
Contributor

krakxn commented Jul 6, 2022

Probably the chainlink core repo.

https://github.com/smartcontractkit/chainlink

I'd like someone from the Chainlink Labs org to do it though, to make sure the style is correct.

I see! Is it okay if I do one myself and make a PR there? Because that way, if necessary, it will be easier for someone from Chainlink Labs to verify/edit the guide. Cheers.

@PatrickAlphaC
Copy link
Contributor Author

Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants