-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OPCORE-948]: fix(chain): peerId is available for bootstrap #88
Merged
graham-chainlink
merged 1 commit into
main
from
ggoh/OPCORE-948/required-peerid-bootstrap
Sep 16, 2024
Merged
[OPCORE-948]: fix(chain): peerId is available for bootstrap #88
graham-chainlink
merged 1 commit into
main
from
ggoh/OPCORE-948/required-peerid-bootstrap
Sep 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkongie
reviewed
Sep 16, 2024
jkongie
reviewed
Sep 16, 2024
graham-chainlink
force-pushed
the
ggoh/OPCORE-948/required-peerid-bootstrap
branch
from
September 16, 2024 13:42
9d33674
to
25673fa
Compare
graham-chainlink
changed the title
[OPCORE-948]: fix(chain): peerId is required for bootstrap
[OPCORE-948]: fix(chain): peerId is available for bootstrap
Sep 16, 2024
Add a new field for peerID in the chain config form when it is running as bootstrap node for OCR2 When `Is this node running as a bootstrap peer?` is selected, peerId is now available as a field.
graham-chainlink
force-pushed
the
ggoh/OPCORE-948/required-peerid-bootstrap
branch
from
September 16, 2024 13:53
25673fa
to
be9296b
Compare
Quality Gate failedFailed conditions |
jkongie
approved these changes
Sep 16, 2024
graham-chainlink
deleted the
ggoh/OPCORE-948/required-peerid-bootstrap
branch
September 16, 2024 14:11
graham-chainlink
added a commit
to smartcontractkit/chainlink
that referenced
this pull request
Sep 16, 2024
Bring in changes for introducing peerId field for OCR2 bootstrap node in chain config page. Reference: smartcontractkit/operator-ui#88 JIRA: https://smartcontract-it.atlassian.net/browse/OPCORE-948
graham-chainlink
added a commit
to smartcontractkit/chainlink
that referenced
this pull request
Sep 16, 2024
Bring in changes for introducing peerId field for OCR2 bootstrap node in chain config page. Reference: smartcontractkit/operator-ui#88 JIRA: https://smartcontract-it.atlassian.net/browse/OPCORE-948
github-merge-queue bot
pushed a commit
to smartcontractkit/chainlink
that referenced
this pull request
Sep 16, 2024
Bring in changes for introducing peerId field for OCR2 bootstrap node in chain config page. Reference: smartcontractkit/operator-ui#88 JIRA: https://smartcontract-it.atlassian.net/browse/OPCORE-948
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new field for peerID in the chain config form when it is running as bootstrap node for OCR2.
When
Is this node running as a bootstrap peer?
is selected, peerId is now available as a field.Context: https://chainlink-core.slack.com/archives/C0577D7CNLV/p1726068910380289?thread_ts=1726068645.524679&cid=C0577D7CNLV
JIRA: https://smartcontract-it.atlassian.net/browse/OPCORE-948
Added p2p peer id info on the chain details
Checklist
If this PR creates changes to the operator-ui itself, rather than tests, pipeline changes, etc. Then please create a changeset so that a new release is created, and the changelog is updated. See: https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md#what-is-a-changeset