From 80a93c1a0e9ce2afa25b1651ef6918855d082d4f Mon Sep 17 00:00:00 2001 From: morenol <22335041+morenol@users.noreply.github.com> Date: Sun, 25 Feb 2024 00:17:30 -0500 Subject: [PATCH] chore: fix clippy (#276) Co-authored-by: Luis Moreno --- src/linalg/basic/matrix.rs | 4 ++-- src/preprocessing/numerical.rs | 10 +++++----- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/linalg/basic/matrix.rs b/src/linalg/basic/matrix.rs index 6b39b55c..47307605 100644 --- a/src/linalg/basic/matrix.rs +++ b/src/linalg/basic/matrix.rs @@ -193,11 +193,11 @@ impl DenseMatrix { /// New instance of `DenseMatrix` from 2d array. pub fn from_2d_array(values: &[&[T]]) -> Self { - DenseMatrix::from_2d_vec(&values.iter().map(|row| Vec::from(*row)).collect()) + DenseMatrix::from_2d_vec(&values.iter().map(|row| Vec::from(*row)).collect::>()) } /// New instance of `DenseMatrix` from 2d vector. - pub fn from_2d_vec(values: &Vec>) -> Self { + pub fn from_2d_vec(values: &[Vec]) -> Self { let nrows = values.len(); let ncols = values .first() diff --git a/src/preprocessing/numerical.rs b/src/preprocessing/numerical.rs index c673731b..bd5f00d1 100644 --- a/src/preprocessing/numerical.rs +++ b/src/preprocessing/numerical.rs @@ -197,11 +197,11 @@ mod tests { fn combine_three_columns() { assert_eq!( build_matrix_from_columns(vec![ - DenseMatrix::from_2d_vec(&vec![vec![1.0], vec![1.0], vec![1.0],]), - DenseMatrix::from_2d_vec(&vec![vec![2.0], vec![2.0], vec![2.0],]), - DenseMatrix::from_2d_vec(&vec![vec![3.0], vec![3.0], vec![3.0],]) + DenseMatrix::from_2d_vec(&[vec![1.0], vec![1.0], vec![1.0]]), + DenseMatrix::from_2d_vec(&[vec![2.0], vec![2.0], vec![2.0]]), + DenseMatrix::from_2d_vec(&[vec![3.0], vec![3.0], vec![3.0]]) ]), - Some(DenseMatrix::from_2d_vec(&vec![ + Some(DenseMatrix::from_2d_vec(&[ vec![1.0, 2.0, 3.0], vec![1.0, 2.0, 3.0], vec![1.0, 2.0, 3.0] @@ -365,7 +365,7 @@ mod tests { ); assert!( - &DenseMatrix::::from_2d_vec(&vec![fitted_scaler.stds]).approximate_eq( + &DenseMatrix::::from_2d_vec(&[fitted_scaler.stds]).approximate_eq( &DenseMatrix::from_2d_array(&[&[ 0.29426447500954, 0.16758497615485,