Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init.model for continuous endpoints #18

Open
NightlordTW opened this issue Aug 31, 2022 · 2 comments
Open

init.model for continuous endpoints #18

NightlordTW opened this issue Aug 31, 2022 · 2 comments
Assignees
Labels
wontfix This will not be worked on

Comments

@NightlordTW
Copy link
Contributor

NightlordTW commented Aug 31, 2022

For continuous outcomes, the user need to specify init.model. Previously, this variable was initialized to a non-specified global variable as follows: init.model = init.model. Since init.model is not defined anywhere in precmed, I have set it equal to NULL by default. However, this issue still needs to be fixed.

#### PRE-PROCESSING ####
  out <- data.preproc.mean(fun = "pm", cate.model = cate.model, init.model = init.model, ps.model = ps.model,
                           score.method = score.method, data = data, prop.cutoff = prop.cutoff, ps.method = ps.method)
@phoebejiang
Copy link
Collaborator

Thanks for bringing this up. Can you be more specific about what the issue is? If we don't deal with continuous outcomes, we do not need to worry about this init.model argument. It does not show up in count or survival cv(). I was able to run cvmean() with init.model = NULL.

@NightlordTW NightlordTW added the wontfix This will not be worked on label Sep 9, 2022
@NightlordTW
Copy link
Contributor Author

We will revisit this issue as soon as the analyses for continuous endpoints are fully implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants