Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve help messages #50

Merged

Conversation

Mopsgeschwindigkeit
Copy link
Contributor

@Mopsgeschwindigkeit Mopsgeschwindigkeit commented Dec 31, 2023

Summary - The What

  • (1) Print help messages if no option or sub_command is given
  • (2) Improved help messages
  • (3) disabled get_sensor_data command
  • (4) return 0 on error and 1 on success
  • (5) In sxapi token -n use builtins.input() to ask for Username instead of sub_command argument.

Purpose - The Why

  • (1) Because this is best practice
  • (2) Better help messages == better UI
  • (3) will be replaced with future commands
  • (4) Because this is best practice
  • (5) I thinks this is more intuitive

ToDo's - Open Point List

DO

  • remove get_sensor_data code
  • Create Enum for Return Values.

Links

image

image

…-command is given, return 0 on success and 1 on failure, adapted sxapi token -n behavior
@Mopsgeschwindigkeit Mopsgeschwindigkeit merged commit c25c9a3 into smaxtec:main Jan 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant