feat: close search button when clicking x
#335
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds behavior to the clear text "x" button while the geosearch is in
button
mode. If there is no text in the search input, the "x" button will additionally close the search input, exactly as if the primary search button itself was clicked. If there is text in in the search input, the button will behave as before, clearing the text but not closing the button.As is, this PR does not make this behavior configurable. There are two reasons for this decision:
This change has no effect on the behavior of the
bar
variant.This functionality was requested in #254.