Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Results list now clears when pressing enter #372

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Results list now clears when pressing enter #372

merged 2 commits into from
Oct 4, 2023

Conversation

tstibbs
Copy link
Contributor

@tstibbs tstibbs commented Jul 25, 2023

Fixes #371.

@tstibbs tstibbs marked this pull request as ready for review July 25, 2023 20:00
@tstibbs tstibbs marked this pull request as draft July 28, 2023 11:13
@tstibbs
Copy link
Contributor Author

tstibbs commented Jul 28, 2023 •
edited
Loading

Note: converted back to draft as I've spotted a bug introduced by this change, which is that pressing enter clears the 'not found' message.

Edit: that bug already existed - it wasn't introduced by this change.

@tstibbs tstibbs marked this pull request as ready for review July 28, 2023 12:07
@smeijer smeijer merged commit 0979b4d into smeijer:develop Oct 4, 2023
8 checks passed
@smeijer
Copy link
Owner

smeijer commented Oct 4, 2023

Thank you!

FYI, this repo qualifies for hacktoberfest contributions if that's your thing.

@smeijer
Copy link
Owner

smeijer commented Oct 4, 2023

🎉 This PR is included in version 3.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smeijer smeijer smeijer approved these changes

Assignees
No one assigned
Labels
released on @develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggestions list - enter key different behaviour to click
2 participants
@tstibbs @smeijer