-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/ErrorEvent with unknown sourceid #577
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Id could be also a reference to an API
…straint where sourceId == "UNKNOWN" is no longer allowed
…ls in case of SourceReference.sourceId == "UNKNOWN"
…nd executeSourceLineTest
lanarimarco
requested review from
benetti-smeup,
mattiabonardi,
FiorenzaBusi and
cosentino-smeup
as code owners
July 23, 2024 13:56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix Issue
When a syntax error occurred after the
/API
directive, theErrorEvent.sourceReference.sourceId
wasUNKNOWN
.Regression due to #573.
The reason for this regression is that the loading and usage of the
API
must follow a well-defined pattern, which the author of the fix in #573 could not know. This pattern was implemented only in theCompilationUnit.includeApi
function. To avoid misuse ofAPI
, I have added the newApiId.loadAndUse
function, which ensures the safe loading and usage of theAPI
.Refactor Test Functions
In the context of this implementation, these useful test functions:
executePgmCallBackTest
executeSourceLineTest
were moved from
JarikoCallbackTest
toAbstractTest
. Consequently, two test units, written specifically for Smeup, were moved fromJarikoCallbackTest
toSmeupInterpreterTest
.In addition, I have added a validation in both functions where if
ErrorEvent.sourceReference.sourceId
isUNKNOWN
, an error is thrown.Overall, this implementation improves the handling of RPG programs with the
/API
directive.Checklist:
./gradlew ktlintCheck
)./gradlew check
)docs
directory