Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/ls24004074/not whole input consumed compiler directives #612

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Bugfix/ls24004074/not whole input consumed compiler directives #612

merged 3 commits into from
Sep 19, 2024

Conversation

dom-apuliasoft
Copy link
Collaborator

Description

Fix an issue where a program containing two COPY containing a IF DEFINED or IF NOT DEFINED directive with the same definition resulted in a wrong file output on the second one if it contained empty lines.

Related to:

  • LS24004074

Checklist:

  • If this feature involves RPGLE fixes or improvements, they are well-described in the summary.
  • There are tests for this feature.
  • RPGLE code used for tests is easily understandable and includes comments that clarify the purpose of this feature.
  • The code follows Kotlin conventions (run ./gradlew ktlintCheck).
  • The code passes all tests (run ./gradlew check).
  • Relevant documentation is included in the docs directory.

lanarimarco
lanarimarco requested changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@lanarimarco lanarimarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A very small change and a suggestion for when you address this kind of issue.

...avaInterpreter-core/src/main/kotlin/com/smeup/rpgparser/parsing/facade/compilerDirectives.kt Outdated Show resolved Hide resolved
@lanarimarco lanarimarco merged commit bcdc832 into develop Sep 19, 2024
1 check passed
@lanarimarco lanarimarco deleted the bugfix/LS24004074/not-whole-input-consumed-compiler-directives branch September 19, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanarimarco lanarimarco lanarimarco approved these changes

@benetti-smeup benetti-smeup Awaiting requested review from benetti-smeup benetti-smeup is a code owner

@mattiabonardi mattiabonardi Awaiting requested review from mattiabonardi mattiabonardi is a code owner

@FiorenzaBusi FiorenzaBusi Awaiting requested review from FiorenzaBusi FiorenzaBusi is a code owner

@cosentino-smeup cosentino-smeup Awaiting requested review from cosentino-smeup cosentino-smeup is a code owner

@foresti-smeup foresti-smeup Awaiting requested review from foresti-smeup foresti-smeup is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dom-apuliasoft @lanarimarco