-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/ls24004056/packed coverage #618
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate implementations where you cut than adding to it! 😊
In addition to my comments on specific files, it seems there's no test that follows this structure:
- Declare a
DS1
withStringType
,NumberType
zoned, andNumberType
packed. - Declare
S1
, a standaloneStringType
similar toDS1
. - Declare
DS2
, structured likeDS1
. - Assign
DS1
toS1
and then assignS1
toDS2
. - Assert that each field of
DS1
is equal to the corresponding field inDS2
.
rpgJavaInterpreter-core/src/test/kotlin/com/smeup/rpgparser/smeup/MULANGT50FileAccess1Test.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a doubt about a test
rpgJavaInterpreter-core/src/test/resources/mute/MUTE13_41.rpgle
Outdated
Show resolved
Hide resolved
As I understand my changes to |
Description
This PR does not add or change any RPG language functionality
From a technical standpoint changes are:
Related to:
Checklist:
./gradlew ktlintCheck
)../gradlew check
).docs
directory.