Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: analytics logs no longer shown #656

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

lanarimarco
Copy link
Collaborator

Description

Fixed regression related to #650.
We moved the push and pop of the current execution program outside the RpgProgram.execute method but overlooked InternalInterpreter.onInterpreterEnd.

Checklist:

  • If this feature involves RPGLE fixes or improvements, they are well-described in the summary.
  • There are tests for this feature.
  • RPGLE code used for tests is easily understandable and includes comments that clarify the purpose of this feature.
  • The code follows Kotlin conventions (run ./gradlew ktlintCheck).
  • The code passes all tests (run ./gradlew check).
  • Relevant documentation is included in the docs directory.

@lanarimarco lanarimarco merged commit 8742c54 into develop Nov 7, 2024
1 check passed
@lanarimarco lanarimarco deleted the bugfix/analytics__logs_no_longer_shown branch November 7, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant