-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/LS24005158/Fix params assignment at the end of program called #675
Merged
lanarimarco
merged 28 commits into
develop
from
feature/LS24005158/fix-params-assignment-at-the-end-of-program-called
Dec 6, 2024
Merged
Bugfix/LS24005158/Fix params assignment at the end of program called #675
lanarimarco
merged 28 commits into
develop
from
feature/LS24005158/fix-params-assignment-at-the-end-of-program-called
Dec 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f Factor 1 and Result, and by adding a reference for Factor 2. This is useful for evaluation at the end of sub program execution
… 2 as attribute of `PlistParam` which could correspond to the `initializationValue`
…nd called, in accord to official documentation of IBM
… is provided, by the value of Result
…nitialize` of `internal_interpreter`
…at-the-end-of-program-called
davidepalladino-apuliasoft
requested review from
lanarimarco,
benetti-smeup,
mattiabonardi,
FiorenzaBusi,
cosentino-smeup and
foresti-smeup
as code owners
December 5, 2024 09:14
…at-the-end-of-program-called
…signment-at-the-end-of-program-called' into feature/LS24005158/fix-params-assignment-at-the-end-of-program-called
lanarimarco
approved these changes
Dec 6, 2024
lanarimarco
deleted the
feature/LS24005158/fix-params-assignment-at-the-end-of-program-called
branch
December 6, 2024 11:40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This work improves the
CALL
andPLIST
(as*ENTRY
) where factors are evaluated in certain circumstance. In accord to official documentation:CALL
:the contents of factor 2,
*IN27
, are placed in the result field,BYTE
. When PROG returns control, the contents of the result field,BYTE
, are placed in the factor 1 field,*IN30
.the contents of the result fields (FieldC and FieldG) of the parameter list are placed in the factor 1 fields (FieldA and FieldD). When the called program returns, the contents of the factor 2 fields of the parameter list (FieldB and FieldE) are placed in the result fields (FieldC and FieldG).
Technical notes
On Jariko this behaviour was not implemented. To achieve this goal, I have firstly re-factorized the
PlistParam
by renaming the attributes in right name for right context; then I have added a new attribute related for Factor 2; finally I have implemented the logic of assignment betweenprogram.kt
andinternal_interpreter.kt
.This resolves the problems thanks to the tests developed and executed on AS400.
Related to #LS24005158
Checklist:
./gradlew ktlintCheck
)../gradlew check
).docs
directory.