Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/ls24005243/checkr factor2 expression #676

Merged
merged 12 commits into from
Dec 10, 2024

Conversation

dom-apuliasoft
Copy link
Collaborator

@dom-apuliasoft dom-apuliasoft commented Dec 4, 2024

Description

Allow support for expressions in factor 2 of CHECK and CHECKR after the :. Execution logic remains the same.

Related to:

  • LS24005243

Checklist:

  • If this feature involves RPGLE fixes or improvements, they are well-described in the summary.
  • There are tests for this feature.
  • RPGLE code used for tests is easily understandable and includes comments that clarify the purpose of this feature.
  • The code follows Kotlin conventions (run ./gradlew ktlintCheck).
  • The code passes all tests (run ./gradlew check).
  • Relevant documentation is included in the docs directory.

@lanarimarco
Copy link
Collaborator

Fix conflict

@lanarimarco lanarimarco self-assigned this Dec 6, 2024
Copy link
Collaborator

@lanarimarco lanarimarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, it could be helpful fixes this issue also for CHECK statement.

Copy link
Collaborator

@lanarimarco lanarimarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I agree with your proposals.

@lanarimarco lanarimarco merged commit f4b5659 into develop Dec 10, 2024
1 check passed
@lanarimarco lanarimarco deleted the bugfix/LS24005243/checkr-factor2-expression branch December 10, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants