-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/LS24005329/Improve comparison between *HIVAL
and String
#683
Bugfix/LS24005329/Improve comparison between *HIVAL
and String
#683
Conversation
…variable defined as `*HIVAL`
…variable defined as `*HIVAL`
…variable defined as `*HIVAL`
…variable defined as `*HIVAL`
…variable defined as `*HIVAL`
…erator, between two variable defined with different number of chars but initialized with `*HIVAL`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation is very clean and closely aligns with what I envisioned to address these issues. However, the tests could be clearer:
- You are using a D-spec of type array, which could lead to the impression that we are fixing something related to arrays.
- The names of the D-specs are
ARR01
andARR02
.
In my opinion, the use of arrays is unnecessary, and the variable names should be more meaningful. For instance, instead of ARR01
or ARR02
, consider using NOHIVAL
and HIVAL
.
Please take these suggestions into account for future implementations.
Description
This work is an improvement for PR #680, by using other comparison operators between
*HIVAL
and String.Related to #LS24005329
Checklist:
./gradlew ktlintCheck
)../gradlew check
).docs
directory.