Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/LS24005329/Improve comparison between *HIVAL and String #683

Conversation

davidepalladino-apuliasoft
Copy link
Collaborator

Description

This work is an improvement for PR #680, by using other comparison operators between *HIVAL and String.

Related to #LS24005329

Checklist:

  • If this feature involves RPGLE fixes or improvements, they are well-described in the summary.
  • There are tests for this feature.
  • RPGLE code used for tests is easily understandable and includes comments that clarify the purpose of this feature.
  • The code follows Kotlin conventions (run ./gradlew ktlintCheck).
  • The code passes all tests (run ./gradlew check).
  • Relevant documentation is included in the docs directory.

Copy link
Collaborator

@lanarimarco lanarimarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation is very clean and closely aligns with what I envisioned to address these issues. However, the tests could be clearer:

  • You are using a D-spec of type array, which could lead to the impression that we are fixing something related to arrays.
  • The names of the D-specs are ARR01 and ARR02.

In my opinion, the use of arrays is unnecessary, and the variable names should be more meaningful. For instance, instead of ARR01 or ARR02, consider using NOHIVAL and HIVAL.

Please take these suggestions into account for future implementations.

@lanarimarco lanarimarco merged commit 1d32783 into develop Dec 12, 2024
1 check passed
@lanarimarco lanarimarco deleted the bugfix/LS24005329/improve-comparison-between-hival-and-string branch December 12, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants