From 9e60f170838e6b09f95c20effab4a25fa6c735c6 Mon Sep 17 00:00:00 2001 From: Andrey Smirnov Date: Wed, 11 Sep 2024 14:07:20 +0400 Subject: [PATCH] fix: remove extra logging on ethtool ioctl failures We should ignore this, it's a totally an optional feature used in containers (Talos on its own kernel has ethtool-netlink). Fixes #9296 Signed-off-by: Andrey Smirnov (cherry picked from commit a9269ac7b1217aa2d247c0215c5f2755af468b44) --- internal/app/machined/pkg/controllers/network/link_status.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/internal/app/machined/pkg/controllers/network/link_status.go b/internal/app/machined/pkg/controllers/network/link_status.go index 60aac145cd..cc6811ce71 100644 --- a/internal/app/machined/pkg/controllers/network/link_status.go +++ b/internal/app/machined/pkg/controllers/network/link_status.go @@ -210,9 +210,7 @@ func (ctrl *LinkStatusController) reconcile( if ethState == nil { state, err := ethtoolIoctlClient.LinkState(link.Attributes.Name) - if err != nil { - logger.Warn("error querying ethtool ioctl link state", zap.String("link", link.Attributes.Name), zap.Error(err)) - } else { + if err == nil { ethState = ðtool.LinkState{ Interface: ethtool.Interface{ Index: int(link.Index),