Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide Serialize/Deserialize implementations #161

Closed
rcoh opened this issue Jan 17, 2021 · 1 comment · Fixed by #530
Closed

Hide Serialize/Deserialize implementations #161

rcoh opened this issue Jan 17, 2021 · 1 comment · Fixed by #530
Assignees
@jdisanti
Labels
medium

Comments

@rcoh
Copy link
Collaborator

rcoh commented Jan 17, 2021

Currently, serialize/deserialize implementations are exposed because the serde traits are public public traits. Ideally, we wouldn't expose that.
@rcoh rcoh added the medium label Jan 17, 2021
@rcoh rcoh assigned ghost May 18, 2021
@rcoh
Copy link
Collaborator Author

rcoh commented May 18, 2021

Part of a larger JSON serialization overhaul

@jdisanti jdisanti assigned jdisanti and unassigned ghost May 19, 2021
This was referenced May 24, 2021
Merged
Merged
Merged
Merged
This was referenced Jun 3, 2021
Merged
Merged
Merged
This was referenced Jun 12, 2021
Merged
Merged
@jdisanti jdisanti mentioned this issue Jun 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdisanti jdisanti

Labels
medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Finish the smithy-json deserializer codegen jdisanti/smithy-rs
2 participants
@jdisanti @rcoh