Add new service builder machinery #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
david-perez
reviewed
Aug 30, 2022
weihanglo
reviewed
Aug 30, 2022
david-perez
approved these changes
Aug 30, 2022
weihanglo
approved these changes
Aug 30, 2022
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
hlbarber
force-pushed
the
harryb/add-service-builder-runtime
branch
from
c3d0445 to
7eb8e1a
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
hlbarber
added a commit
that referenced
this pull request
Sep 12, 2022
* Add `ServerProtocol` interface to allow for server side protocol specific methods. * Make public the structs merged in #1679. * Add `ServerOperationGenerator`, which generates a ZST and implements `OperationShape` on it. * Add `ServerServiceGeneratorV2`, which generates the service newtype around a router and a service builder. * Add `hidden` argument to `RustModule` which allows modules to be marked with `#[doc(hidden)]`. * Add `BuildModifier` trait to provide a common interface for extending service builders. * Add `Upgradable` trait to simplifying bounds when upgrading from an `Operation` to a HTTP service. * Add `FromRequest`, `FromParts`, and `IntoResponse` implementations. * Make `RoutingService` accept general body types `B` for the inner services `http::Response<B>`. * Use new service builder in protocol tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#1620
Description
FromRequestandFromParts.OperationShapetrait to model Smithy operations.HandlerandOperationServicetraits.UpgradeServiceandUpgradeLayerLayer.