-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rfc30/compiletime benchmark to ci #2775
Open
thomas-k-cameron
wants to merge
76
commits into
smithy-lang:main
Choose a base branch
from
thomas-k-cameron:RFC30/compiletime-benchmark-to-ci
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Rfc30/compiletime benchmark to ci #2775
thomas-k-cameron
wants to merge
76
commits into
smithy-lang:main
from
thomas-k-cameron:RFC30/compiletime-benchmark-to-ci
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add scripts
Hi, The issue we had is fixed now. Test was done by adding a ci-action to |
…m/thomas-k-cameron/smithy-rs into RFC30/compiletime-benchmark-to-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Compile time benchmark was merged before but it was reverted as it was causing error.
This one has it's error fixed.
Test for this CI can be found here.
https://github.com/awslabs/smithy-rs/actions/runs/5299211765/jobs/9592047342
Testing
https://github.com/awslabs/smithy-rs/actions/runs/5299211765/jobs/9592047342
Checklist
CHANGELOG.next.toml
if I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.toml
if I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.