Lazy decryption for keyfiles #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When performing signing for a given key, gpg will interrogate the gpg-agent for availability of keygrips of _all_ signing keys, not just the one that ends up being used for the actual signing. piv-agent used to pre-emptively decrypted the keyfiles when checking them against the supplied keygrip. This change causes it to wait until the actual point of signature before decrypting the keyfiles. This means that you avoid a pinentry prompt for keyfiles when signing using a hardware security device. This change also makes a couple of error handling changes to make piv-agent more robust when cancelling or failing pinentry prompts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing signing for a given key, gpg will interrogate the
gpg-agent for availability of keygrips of all signing keys, not just
the one that ends up being used for the actual signing.
piv-agent used to pre-emptively decrypted the keyfiles when checking
them against the supplied keygrip. This change causes it to wait until
the actual point of signature before decrypting the keyfiles.
This means that you avoid a pinentry prompt for keyfiles when signing
using a hardware security device.
This change also makes a couple of error handling changes to make
piv-agent more robust when cancelling or failing pinentry prompts.
Closes: #58