Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't activate Perish Body if either Pokémon has a perish count #10872

Merged
merged 4 commits into from
Feb 9, 2025

Conversation

andrebastosdias
Copy link
Contributor

closes #10858

@urkerab
Copy link
Contributor

urkerab commented Feb 9, 2025

(Although this will work it does allow for a simplification of the rest of the code as you know for example that the ability will always announce at this point.)

@DaWoblefet
Copy link
Member

Tested on cart and this happens if either the attacker or the target already have a Perish counter. So you just need to add a check for the target's volatiles too.

@andrebastosdias andrebastosdias changed the title Don't activate Perish Body if the attacker has a perish count Don't activate Perish Body if either Pokémon has a perish count Feb 9, 2025
@DaWoblefet DaWoblefet merged commit d26e34e into smogon:master Feb 9, 2025
1 check passed
@DaWoblefet
Copy link
Member

Thanks Hydrametr0nice!

@andrebastosdias andrebastosdias deleted the patch-2 branch February 9, 2025 04:37
@DayKev
Copy link

DayKev commented Feb 9, 2025

What do you mean "or the target"? In the context of this ability activating there's an attacker and a defender, so I'm not sure which one (or neither?) is supposed to be the target.
In case you're referring to defender I have a video of it activating if the defender but not the attacker have the Perish status already. Is this in relation to double battles maybe?

2024091422340400-3C66B776DB1AA06323037049FACD96D3.mp4

@andrebastosdias
Copy link
Contributor Author

@DaWoblefet is this a generation discrepancy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Perish Body incorrectly activates on the defender if the attacker is already afflicted with Perish
4 participants