Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async-channel 2.3.0 fails to compile with concurrent-queue below 2.5.0 #92

Closed
creberust opened this issue May 13, 2024 · 0 comments · Fixed by #93
Closed

Async-channel 2.3.0 fails to compile with concurrent-queue below 2.5.0 #92

creberust opened this issue May 13, 2024 · 0 comments · Fixed by #93

Comments

@creberust
Copy link

Hi,

The selected version of concurrent-queue is incorrect in the Cargo.toml and should be at least 2.5 since #89 .

async-channel version 2.3.0 use ForcePushError which is only available since concurrent-queue version 2.5.0.

Thus, if you have any version prior to 2.5.0 in your Cargo.lock, it will not compile. (This actually fails only if you have a version of concurrent-queue previously set to 2.4.0, the others versions are not compatible with event-listener, which is used by concurrent-queue).

Simple steps to reproduce the error:

cargo new ac-bug
cd ac-bug

cargo add async-channel@2.3.0

# Everything works fine because `cargo` will pull the last version of `concurrent-queue` with 2.x.y.
cargo b

# This is valid because `concurrent-queue` should be `^2.4.0` thanks to `event-listener`.
cargo update concurrent-queue --precise 2.4.0 

# Note: This will be rejected
cargo update concurrent-queue --precise 2.3.0
 
# Kaboom
cargo b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant