Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OnceCell is possibly missing a Default impl #62

Closed
SeaDve opened this issue Nov 8, 2023 · 1 comment · Fixed by #63
Closed

OnceCell is possibly missing a Default impl #62

SeaDve opened this issue Nov 8, 2023 · 1 comment · Fixed by #63

Comments

@SeaDve
Copy link

SeaDve commented Nov 8, 2023

The std OnceCell implements it, and it seems viable since OnceCell::new doesn't take a parameter or return a value other than itself.
@notgull
Copy link
Member

notgull commented Nov 8, 2023

I would accept a PR adding this

@Jules-Bertholet Jules-Bertholet mentioned this issue Nov 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement Default for OnceCell Jules-Bertholet/async-lock
2 participants
@notgull @SeaDve