-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.3.0 #94
Merged
Merged
v2.3.0 #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build failure is #95 |
notgull
force-pushed
the
notgull/next
branch
from
February 26, 2024 02:07
97cca7f
to
50c3bab
Compare
|
notgull
force-pushed
the
notgull/next
branch
from
February 29, 2024 05:20
50c3bab
to
e83fac5
Compare
Hmm, good point. What if we called it |
Hmm, "ready" is already used in multiple meanings... (task::ready!, future::ready) |
Scattershot other suggestions:
|
Drain would also match the semantics around Vec::drain which is an iterator that also removes every element from the container. |
taiki-e
reviewed
Mar 16, 2024
taiki-e
approved these changes
Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StreamExt::try_iter
for polling aStream
while it is ready. (Add a Stream::try_iter() method #70)