Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write unit tests to improve coverage #52

Closed
ghost opened this issue Apr 28, 2020 · 6 comments
Closed

Write unit tests to improve coverage #52

ghost opened this issue Apr 28, 2020 · 6 comments
Labels
good first issue Good for newcomers

Comments

@ghost
Copy link

ghost commented Apr 28, 2020

Right now, the reported coverage on the badge in readme is 31%. Let's get it to 100%!

@ghost
Copy link
Author

ghost commented Apr 28, 2020

PRs are welcome! If you'd like to contribute, this is an easy way to get started :)

@wusyong
Copy link
Contributor

wusyong commented May 1, 2020

Wrote a few tests and run them a bit, I realized there are way too many branch conditions need to cover. Maybe we should disable branch info? What we want to make sure is line and function coverage are good enough. Trying to satisfy them all is not practical imho.

@ghost
Copy link
Author

ghost commented May 1, 2020

@wusyong That sounds reasonable - I think covering all branches is a bar too high.

@tshepang
Copy link
Contributor

tshepang commented May 1, 2020

Another way to look at it is for 31% not be seen as bad, as in there is no need to get to 100%. That is, it's good to know that some branches are not covered. Does the service make it easy to see non-branch coverage results?

@wusyong
Copy link
Contributor

wusyong commented May 2, 2020

@tshepang I think you are right. It just confused me when I added a test but the rate becomes lower because of more branch misses. Configure this should be easy anyway. I guess this comes down to what's the goal for the code coverage rate we are going to show (line/branch/path).

@ghost ghost added the good first issue Good for newcomers label May 3, 2020
@ghost
Copy link
Author

ghost commented Jul 15, 2020

Unit tests have moved into the smaller subcrates. See #188

@ghost ghost closed this as completed Jul 15, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Development

No branches or pull requests

2 participants