Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support child frames #275

Merged
merged 3 commits into from
Aug 28, 2019
Merged

add support child frames #275

merged 3 commits into from
Aug 28, 2019

Conversation

Mavrin
Copy link
Contributor

@Mavrin Mavrin commented Aug 12, 2019

Summary

When I pass child frame instance to expectPuppeteer, I get error Frame is not supported.

  const frame = page.frames().find(frame => frame.name() === 'myframe');
  const text = expectPuppeteer(frame).toClick('.selector');

@gregberge
Copy link
Member

Hello @Mavrin, thanks for your work, it is very good!

@gregberge gregberge merged commit 09703ea into argos-ci:master Aug 28, 2019
@yesmeck
Copy link

yesmeck commented Nov 21, 2019

@neoziro Could you make a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants