fix(server): ignore source maps

Source maps must no be included in links. See #128
gregberge · Nov 13, 2018 · 9991bbd · 9991bbd
1 parent 1ea8465
commit 9991bbd
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 17 deletions.
diff --git a/packages/server/__fixtures__/stats.json b/packages/server/__fixtures__/stats.json
@@ -169,7 +169,8 @@
       },
       "childAssets": {
         "preload": [
-          "letters-C.js"
+          "letters-C.js",
+          "letters-C.js.map"
         ],
         "prefetch": [
           "letters-D.js"

diff --git a/packages/server/src/ChunkExtractor.js b/packages/server/src/ChunkExtractor.js
@@ -111,14 +111,16 @@ class ChunkExtractor {
   getChunkAssets(chunks) {
     const one = chunk => {
       const chunkGroup = this.getChunkGroup(chunk)
-      return chunkGroup.assets.map(filename =>
-        this.createChunkAsset({
-          filename,
-          chunk,
-          type: 'mainAsset',
-          linkType: 'preload',
-        }),
-      )
+      return chunkGroup.assets
+        .map(filename =>
+          this.createChunkAsset({
+            filename,
+            chunk,
+            type: 'mainAsset',
+            linkType: 'preload',
+          }),
+        )
+        .filter(chunkAsset => chunkAsset.scriptType)
     }
 
     if (Array.isArray(chunks)) {
@@ -132,14 +134,16 @@ class ChunkExtractor {
     const one = chunk => {
       const chunkGroup = this.getChunkGroup(chunk)
       const assets = chunkGroup.childAssets[type] || []
-      return assets.map(filename =>
-        this.createChunkAsset({
-          filename,
-          chunk,
-          type: 'childAsset',
-          linkType: type,
-        }),
-      )
+      return assets
+        .map(filename =>
+          this.createChunkAsset({
+            filename,
+            chunk,
+            type: 'childAsset',
+            linkType: type,
+          }),
+        )
+        .filter(chunkAsset => chunkAsset.scriptType)
     }
 
     if (Array.isArray(chunks)) {