fix(server): ignore *.hot-update.js

Closes #148
gregberge · Nov 20, 2018 · edcd2c8 · edcd2c8
1 parent ec95e15
commit edcd2c8
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/packages/server/__fixtures__/stats.json b/packages/server/__fixtures__/stats.json
@@ -141,7 +141,8 @@
       ],
       "assets": [
         "main.css",
-        "main.js"
+        "main.js",
+        "main.hot-update.js"
       ],
       "children": {
         "preload": [

diff --git a/packages/server/src/ChunkExtractor.js b/packages/server/src/ChunkExtractor.js
@@ -76,6 +76,12 @@ function joinTags(tags) {
   return tags.join('\n')
 }
 
+const HOT_UPDATE_REGEXP = /\.hot-update\.js$/
+
+function isValidChunkAsset(chunkAsset) {
+  return chunkAsset.scriptType && !HOT_UPDATE_REGEXP.test(chunkAsset.filename)
+}
+
 class ChunkExtractor {
   constructor({ statsFile, stats, entrypoints = ['main'], outputPath } = []) {
     this.stats = stats || smartRequire(statsFile)
@@ -120,7 +126,7 @@ class ChunkExtractor {
             linkType: 'preload',
           }),
         )
-        .filter(chunkAsset => chunkAsset.scriptType)
+        .filter(isValidChunkAsset)
     }
 
     if (Array.isArray(chunks)) {
@@ -143,7 +149,7 @@ class ChunkExtractor {
             linkType: type,
           }),
         )
-        .filter(chunkAsset => chunkAsset.scriptType)
+        .filter(isValidChunkAsset)
     }
 
     if (Array.isArray(chunks)) {