Exclude http and https from regex. Should fix #153

[patrickhaug]

The regex now excludes leading http (https). There was a failing test before. Should I look after that one?

[patrickhaug]

Yeah, saw that too after pushing... but that failing test was something different? 😕

[gregberge]

@patrickhaug thanks, can you add a test?

To do it create a new file util.test.js :

describe('util', () => {
  describe('#joinURLPath', () => {
    it('should join paths', () => {
      expect(joinURLPath('a', 'b')).toBe('a/b')
    })
  })
})

Please add the one that was causing problem, thanks!

[gregberge]

Thanks 🙏

[willdurand]

Hi, I think this still fails if the publicPath is protocol-free (e.g., //127.0.0.1:3001).

[patrickhaug]

@willdurand yup, this will fail. I opened a PR