fix: Add extra props option for links #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @MattsJones, it looks good for me. Can you update the documentation please? |
|
Hey @neoziro. Not sure what you'd like updated in the docs? As I mentioned in the PR description the feature was already documented in the previous release but missed out on the actual implementation. |
|
OK sorry, so I merge it! Thanks! |
|
Any chance we could release this? Would be really appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add extra prop options for
getLinkTagsandgetLinkElements.The latest version added extra prop options for all the get tag functions. It seems as though links were missed in this even though they were documented as having the option.
Test plan
Added snapshot tests for the new options.
Note: I ran prettier over the project but it seemed to change some extra lines. Not sure if it was upto date previously.