Allow query-param cache busting in chunk names #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @jordanburk, thanks, can you add a test please? |
|
Hi @neoziro , sorry about that! I have added tests as requested. Please let me know if they are sufficient, thank you ^_^ |
|
Yes all good for me thanks! |
|
Hi @neoziro, thank you for accepting this. Any estimate on when it will be released? Hoping to get this in use on production soon. |
|
Released! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use query params for cache-busting (eg,
chunkFilename: '[name].js?[chunkhash]'), butextname()can't properly get the extension when there's a param attached. This change would allow the use of query params.