Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): fix loading order of assets #266

Merged
merged 1 commit into from
Mar 13, 2019

Conversation

ambar
Copy link
Contributor

@ambar ambar commented Mar 12, 2019

Summary

Related: #235

Test plan

Before

<!-- links -->
<link rel="preload" as="style" href="/static/css/Home.ab6fee9e.chunk.css">
<link rel="preload" as="script" href="/static/js/Home.29540c57.chunk.js">
<link rel="preload" as="script" href="/static/js/Logo.aa3dfd51.chunk.js">
<link rel="preload" as="script" href="/static/js/Welcome.b8e5d508.chunk.js">
<link rel="preload" as="script" href="/static/js/Intro.a96fcb22.chunk.js">
<link rel="preload" as="script" href="/static/js/runtime~client.0a907542.js">
<link rel="preload" as="style" href="/static/css/9.24bf1742.chunk.css">
<link rel="preload" as="script" href="/static/js/9.47319bf4.chunk.js">
<link rel="preload" as="style" href="/static/css/client.9823d995.chunk.css">
<link rel="preload" as="script" href="/static/js/client.3ed3a225.chunk.js">

<!-- styles -->
<link rel="stylesheet" href="/static/css/Home.ab6fee9e.chunk.css">    <!-- page -->
<link rel="stylesheet" href="/static/css/9.24bf1742.chunk.css">       <!-- vendor -->
<link rel="stylesheet" href="/static/css/client.9823d995.chunk.css">  <!-- entry -->

<!-- scripts -->
<script id="__LOADABLE_REQUIRED_CHUNKS__" type="application/json">[2,4,6,3]</script>
<script async src="/static/js/Home.29540c57.chunk.js"></script>
<script async src="/static/js/Logo.aa3dfd51.chunk.js"></script>
<script async src="/static/js/Welcome.b8e5d508.chunk.js"></script>
<script async src="/static/js/Intro.a96fcb22.chunk.js"></script>
<script async src="/static/js/runtime~client.0a907542.js"></script> <!-- runtime -->
<script async src="/static/js/9.47319bf4.chunk.js"></script>        <!-- vendor -->
<script async src="/static/js/client.3ed3a225.chunk.js"></script>   <!-- entry -->

After

<!-- links -->
<link rel="preload" as="script" href="/static/js/runtime~client.0a907542.js">
<link rel="preload" as="style" href="/static/css/9.24bf1742.chunk.css">
<link rel="preload" as="script" href="/static/js/9.47319bf4.chunk.js">
<link rel="preload" as="style" href="/static/css/client.9823d995.chunk.css">
<link rel="preload" as="script" href="/static/js/client.3ed3a225.chunk.js">
<link rel="preload" as="style" href="/static/css/Home.ab6fee9e.chunk.css">
<link rel="preload" as="script" href="/static/js/Home.29540c57.chunk.js">
<link rel="preload" as="script" href="/static/js/Logo.aa3dfd51.chunk.js">
<link rel="preload" as="script" href="/static/js/Welcome.b8e5d508.chunk.js">
<link rel="preload" as="script" href="/static/js/Intro.a96fcb22.chunk.js">

<!-- styles -->
<link rel="stylesheet" href="/static/css/9.24bf1742.chunk.css">       <!-- vendor -->
<link rel="stylesheet" href="/static/css/client.9823d995.chunk.css">  <!-- entry -->
<link rel="stylesheet" href="/static/css/Home.ab6fee9e.chunk.css">    <!-- page -->

<!-- scripts -->
<script id="__LOADABLE_REQUIRED_CHUNKS__" type="application/json">[2,4,6,3]</script>
<script async src="/static/js/runtime~client.0a907542.js"></script> <!-- runtime -->
<script async src="/static/js/9.47319bf4.chunk.js"></script>        <!-- vendor -->
<script async src="/static/js/client.3ed3a225.chunk.js"></script>   <!-- entry -->
<script async src="/static/js/Home.29540c57.chunk.js"></script>
<script async src="/static/js/Logo.aa3dfd51.chunk.js"></script>
<script async src="/static/js/Welcome.b8e5d508.chunk.js"></script>
<script async src="/static/js/Intro.a96fcb22.chunk.js"></script>

@gregberge gregberge merged commit 4c8ae60 into gregberge:master Mar 13, 2019
@gregberge
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants