implement attribute function #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregberge
requested changes
Mar 19, 2019
| extraProps, | ||
| )}>${this.getRequiredChunksScriptContent()}</script>` | ||
| } | ||
|
|
||
| getRequiredChunksScriptElement(extraProps) { | ||
| getRequiredChunksScriptElement(asset, extraProps) { |
There was a problem hiding this comment.
I don't understand this change. Why changing this signature, you can just call handleExtraProps(null, extraProps).
gregberge
approved these changes
Mar 19, 2019
There was a problem hiding this comment.
Thanks! Could you add some documentation @salzhrani about the new feature on the website?
|
@salzhrani any news? |
|
@neoziro I just added some documentation. |
|
@salzhrani thanks, one last thing, could you rebase please? |
salzhrani
force-pushed
the
attribute-function
branch
from
5557baf
to
008084b
Compare
|
rebased |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow the attributes arguments to be a function to possibly map the chunks to attributes.
Currently it uses the same argument but checks if it is a function or an object.
Also the attribute function could get
nullas an argument in case the__LOADABLE_REQUIRED_CHUNKS__tagLooking forward to your feedback.
Test plan
tests included