feat: add load method that returns a Promise
#329
Conversation
See #226 for context
|
@theKashey could you review it please? |
| @@ -195,6 +195,13 @@ function createLoadable({ resolve = identity, render, onLoad }) { | |||
| ctor.requireAsync(props) | |||
| } | |||
|
|
|||
| Loadable.load = props => { | |||
| if (typeof window === 'undefined') { | |||
| throw new Error('`load` cannot be called server-side') | |||
There was a problem hiding this comment.
It is really has to be an error?
There was a problem hiding this comment.
Another issue, for now I will let it like this.
There was a problem hiding this comment.
I was happy to see this PR but looking at the code I can not use it because of this limitation. I need as much client side as server.
There was a problem hiding this comment.
Thank you, that would be perfect with a method like isReady.
There was a problem hiding this comment.
Yep, but remember, if you need it, you are probably taking the wrong way to be Suspense ready. When Suspense will be released, you will not be able to wait for anything except in render.
There was a problem hiding this comment.
I know that Suspense does not allow it, but it's still useful information. In my case it allows me to display a progress bar when you have to load one or more chunks and not display it when they are already loaded.
There was a problem hiding this comment.
Ooff, how many chunks you have to load?
|
😍, welcome to the club |
See gregberge#226 for context
See #226 for context.