Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use more performant url join impl #353

Merged
merged 1 commit into from
Jun 5, 2019
Merged

Conversation

hulkish
Copy link
Contributor

@hulkish hulkish commented May 30, 2019

Summary

Test plan

yarn test packages/server/src/util.test.js
yarn run v1.16.0
$ jest packages/server/src/util.test.js
 PASS  packages/server/src/util.test.js
  util
    #joinURLPath
      ✓ should join paths with relative public path (2ms)
      ✓ should join paths starting with "/" (1ms)
      ✓ should join paths with absolute public path
      ✓ should join paths with protocol free public path

Test Suites: 1 passed, 1 total
Tests:       4 passed, 4 total
Snapshots:   0 total
Time:        0.869s, estimated 1s
Ran all test suites matching /packages\/server\/src\/util.test.js/i.
✨  Done in 2.02s.

@gregberge gregberge merged commit c3fbbef into gregberge:master Jun 5, 2019
@gregberge
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants