Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IE11: Object doesn't support property or method 'includes' #397

Closed
c1aphas opened this issue Jul 30, 2019 · 2 comments · Fixed by #416
Closed

IE11: Object doesn't support property or method 'includes' #397

c1aphas opened this issue Jul 30, 2019 · 2 comments · Fixed by #416
Labels
bug

Comments

@c1aphas
Copy link

c1aphas commented Jul 30, 2019

🐛 Bug Report

Hi!
According to docs browser support is:

v5.x (React v16.3+): IE11, IE 9+ (with Map + Set polyfills), all evergreen browsers

But my project fails on this line https://github.com/smooth-code/loadable-components/blob/d7c3f58059a798dc1d38f95da79f374e998977ad/packages/component/src/loadableReady.js#L44

includes doesn't supported in IE up to ie11

Am i doing something wrong? My project uses razzle boilerplate with loadable-components example: https://github.com/smooth-code/loadable-components/tree/master/examples/razzle
@gregberge
Copy link
Owner

Hmm yes you are right, for now you can just include the polyfill. Could you submit a PR to fix it?

@gregberge gregberge added the bug label Aug 6, 2019
@gregberge
Copy link
Owner

By fixing it I mean using indexOf instead of includes.

Haroenv added a commit to Haroenv/loadable-components that referenced this issue Aug 22, 2019
@Haroenv
support ie11
9ab2674 
I didn't check this, but it seems trivial

fixes gregberge#397
@Haroenv Haroenv mentioned this issue Aug 22, 2019
Merged
gregberge pushed a commit that referenced this issue Aug 28, 2019
@Haroenv @gregberge
fix: support IE 11 without polyfill (#416)
80ee809 
Fixes #397
fivethreeo pushed a commit to fivethreeo/loadable-components that referenced this issue Nov 16, 2022
@Haroenv @gregberge
fix: support IE 11 without polyfill (gregberge#416)
9be227d 
Fixes gregberge#397
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

support ie11 Haroenv/loadable-components
2 participants
@gregberge @c1aphas