Babel plugin: Fixed bug when using + concatenation instead of a template literal #425
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, the Babel plugin successfully transpiles template literals, but doesn't work when building a string using
+
. i.e. this works:But this does not:
The latter fails with an error:
This PR fixes this issue by checking to see if the import expression is a BinaryExpression. I'm not sure if there are any other types of expressions that should be checked for, but this solves the issue for BinaryExpressions at least.
Test plan
I added a new test to verify that it works and also tested it in a real app.