fix: empty cache on chunks for each server reload #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! |
|
Thank you for merging this @neoziro ! Do you have a rough idea when you will publish a new release? We can patch the module manually for now but if you plan to do one in the near future we'd rather use it directly. |
|
Just released it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #230
Summary
Fixes the fact that in some cases the async chunks were not correctly reloaded on the server while correctly reloaded on the client.
Test plan
Follow what was described in #230
It works on my machine ™️
On a separate repo though. I didn't test with the examples provided in this repo because I couldn't make them work even before my fix.
Have a nice day 👋
PS: Sorry about the many
push -f😛 Having a bad day with git!