On client-side init error return rejected promise rather than throw #87
Conversation
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
======================================
+ Coverage 88.5% 90.5% +2%
======================================
Files 15 15
Lines 200 200
Branches 54 54
======================================
+ Hits 177 181 +4
+ Misses 21 17 -4
Partials 2 2
Continue to review full report at Codecov.
|
|
Thanks for this improvement, but if you use |
|
Ah! Updated (was up working much too late). |
damassi
force-pushed
the
dont-throw
branch
7 times, most recently
from
aef0ce6
to
c351cff
Compare
|
I've updated tests to cover each error branch but I can't figure out how to stub |
src/loadComponents.js
Outdated
| }" is not found, client and server modules are not sync. You are probably not using the same resolver on server and client.` | ||
|
|
||
| console.error(errorMessage) | ||
| return Promise.reject(errorMessage) |
There was a problem hiding this comment.
I think we should just do return Promise.reject(new Error(...)), it should be sufficient. So :
- Please remove log
- Please call
Promise.rejectwith an error
There was a problem hiding this comment.
return Promise.reject(new Error(...)) is much cleaner 👍
|
@damassi don't worry about test coverage it is not a problem. |
damassi
force-pushed
the
dont-throw
branch
2 times, most recently
from
11ab531
to
0bc00fc
Compare
damassi
changed the title
|
@damassi tests are broken :/ |
|
@neoziro - looks like a CI thing -- let me kick off another commit... |
|
thanks! |
This swaps out an error with a rejected promise so that client UI doesn't break. Noticed when used in conjunction with
@artsy/express-reloadablethat when reloads occur and module ids increment an error occurs when really there's no problem.(Really excellent lib -- was totally painless to setup compared to all of the others 👍)