fix: Clear correct cache when compiling with Webpack

[Mordred]

Summary

Using module.hot is forcing me to use Webpack HotModuleReplacementPlugin and excluding @loadable/server from nodeExternal() so that module.hot is present. (8f10896)

Then __non_webpack_require__ is used in smartRequire (https://github.com/gregberge/loadable-components/blob/main/packages/server/src/util.js#L30) but clearModuleCache is clearing cache from require not from __non_webpack_require__.

This PR should fix this problem.

Test plan

See #821

[theKashey]

Sorry, took some time to connect all the dots and pieces and understand how it's working, or how it's not working :)

You are absolutely correct, smartRequire and clearCache should use the same "source" for module information.

[theKashey]

Sorry for being picky, but let's safe future developers time and make it right this time

Let's use "single source" for both operations if the HAVE to be synchronized.

const getRequire = () => typeof __non_webpack_require__ !== 'undefined' ? __non_webpack_require__ : require;

export const clearModuleCache = moduleName => {
  const cache = getRequire().cache; // 👈
...
}

export const smartRequire = modulePath => {
  if (process.env.NODE_ENV !== 'production' && module.hot) {
    clearModuleCache(modulePath)
  }
 
  return getRequire(moduleName);  // 👈
}

[theKashey]

The approach is correct. Let's make it ideal

[Mordred]

@theKashey OK, no problem. I've refactored it based on your suggestions and kept eval - not sure if it is necessary, but it was there in original code.

[theKashey]

thank you for your contribution, I will release the update shortly.

[kiyasov]

thank you for your contribution, I will release the update shortly.

Hi! When will it be released?

[rtymchyk]

Would appreciate a release with this commit when possible 🙏

[rtymchyk]

🦗

[theKashey]

🙄😅

[theKashey]

https://github.com/gregberge/loadable-components/releases/tag/v5.15.2