Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: loadAsync resolve #839

Merged
merged 1 commit into from
Sep 26, 2021
Merged

fix: loadAsync resolve #839

merged 1 commit into from
Sep 26, 2021

Conversation

jinasonlin
Copy link
Contributor

Summary

I think loadAsync should like loadSync resolve module and copy Component statics (hoistNonReactStatics).

In some cases, I hope loadable can trigger load end, so add onLoad in options.

Test plan

@theKashey
Copy link
Collaborator

  • I can approve your first change, as it's a bug fix
  • I can not approve your second change, as it lacking: tests, documentation, an update to typescript definitions. Unfortunately, you cannot "just add" a new field to the option, especially as a part of another change.

@jinasonlin
Copy link
Contributor Author

Okay, I'll split the PR. Please review the fix.

@jinasonlin jinasonlin changed the title feat: optimize loadAsync resolve and add onLoad in options fix: loadAsync resolve Sep 24, 2021
@theKashey
Copy link
Collaborator

👍

@theKashey theKashey merged commit 9ff6693 into gregberge:main Sep 26, 2021
@jinasonlin jinasonlin mentioned this pull request Oct 18, 2021
Closed
@theKashey
Copy link
Collaborator

https://github.com/gregberge/loadable-components/releases/tag/v5.15.2

fivethreeo pushed a commit to fivethreeo/loadable-components that referenced this pull request Nov 16, 2022
@jinasonlin
fix: loadAsync Loadable should copy statics (gregberge#839)
395a991
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jinasonlin @theKashey