Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline Queue - configurable #80

Closed
youngamichael opened this issue Jul 16, 2018 · 2 comments
Closed

Offline Queue - configurable #80

youngamichael opened this issue Jul 16, 2018 · 2 comments

Comments

@youngamichael
Copy link

First off, I like this library. I wish there was a configuration for the offline queue feature to shut it off. When you call send and redis is down it pushes the message into the offline queue. The problem I see with that is redis could be down for a while and you have a potential to back up fairly significantly. It isn't written to disk so if the program would crash those messages would be lost. In some cases the offline queue maybe very useful but I wish there was a configuration option to just callback with an error so further steps could be taken upstream.

@rogerweb
Copy link

There is. It's the enable_offline_queue of the redis module itself. Check here: https://github.com/NodeRedis/node_redis#options-object-properties

Cheers,

Roger

@youngamichael
Copy link
Author

Doh! just realized I put this message in the wrong github repo... Thanks for the response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants