Rector updates #1989
Merged
Rector updates #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done for both local testing and GitHub Actions. Use `--dry-run` so that no changes are made during testing.
Use the new fluent interface for setting up the rector configuration. No functionality changes.
This is a regression from a previously added rule. See 78baae6.
This rule makes expressions like this safer because we only write out the variable name once.
This rule simplifies the class interface by combining the ctor argument with the property declaration.
If class properties are never set outside the ctor, they can be marked as readonly.
No changes, but is something we want to make sure is done in the future. Related to smrealms#1775.
Explicitly declare types for all class constants. Related to smrealms#1775.
Static methods do not need to be called on a class instance, and so they should use the static context, even if a class instance is present.
This makes the expression safer since we only write out the variable name once.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1989 +/- ##
============================================
- Coverage 31.48% 31.45% -0.03%
+ Complexity 4207 4205 -2
============================================
Files 125 125
Lines 12820 12815 -5
============================================
- Hits 4036 4031 -5
Misses 8784 8784 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more rector rules and include it in standard testing (local and GHA).