engine: Set shm path to "app/$name" #766
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the shared memory path (shm.path) to a private namespace for each app with prefix "app/$name". This means that apps can create shm objects such as counters and by default these will appear in a local namespace for that app.
|
By analyzing the blame information on this pull request, we identified @eugeneia, @javierguerragiraldez and @nnikolaev-virtualopensystems to be potential reviewers |
| @@ -65,6 +66,8 @@ end | |||
| -- Run app:methodname() in protected mode (pcall). If it throws an | |||
| -- error app will be marked as dead and restarted eventually. | |||
| local function with_restart (app, method) | |||
There was a problem hiding this comment.
I guess we should rename with_restart to something like invoke_app_method. Nothing critical but this change makes the functions name a misnomer.
There was a problem hiding this comment.
@lukego Do you want to rename with_restart before I merge this or leave it as is?
eugeneia
added a commit
to eugeneia/snabb
that referenced
this pull request
Apr 12, 2016
- Use "apps/" instead of "app/" for uniformity - Set shm path to "apps/$name" when calling `app:stop' too - Unlink "apps/$name" after `app:stop' using `shm.unlink' - Add a test case to core.app selftest
eugeneia
added a commit
to eugeneia/snabb
that referenced
this pull request
Apr 12, 2016
- Use "apps/" instead of "app/" for uniformity - Set shm path to "apps/$name" when calling `app:stop' too - Unlink "apps/$name" after `app:stop' using `shm.unlink' - Add a test case to core.app selftest
eugeneia
added a commit
to eugeneia/snabb
that referenced
this pull request
Apr 12, 2016
- Use "apps/" instead of "app/" for uniformity - Set shm path to "apps/$name" when calling `app:stop' too - Unlink "apps/$name" after `app:stop' using `shm.unlink' - Add a test case to core.app selftest
eugeneia
added a commit
to eugeneia/snabb
that referenced
this pull request
Apr 12, 2016
- Use "apps/" instead of "app/" for uniformity - Set shm path to "apps/$name" when calling `app:stop' too - Unlink "apps/$name" after `app:stop' using `shm.unlink' - Add a test case to core.app selftest
eugeneia
added a commit
to eugeneia/snabb
that referenced
this pull request
Apr 12, 2016
- Use "apps/" instead of "app/" for uniformity - Set shm path to "apps/$name" when calling `app:stop' too - Unlink "apps/$name" after `app:stop' using `shm.unlink' - Add a test case to core.app selftest
eugeneia
added a commit
to eugeneia/snabb
that referenced
this pull request
Apr 12, 2016
- Use "apps/" instead of "app/" for uniformity - Set shm path to "apps/$name" when calling `app:stop' too - Unlink "apps/$name" after `app:stop' using `shm.unlink' - Add a test case to core.app selftest
eugeneia
added a commit
to eugeneia/snabb
that referenced
this pull request
Apr 12, 2016
# Conflicts: # src/core/app.lua
eugeneia
added a commit
to eugeneia/snabb
that referenced
this pull request
Jun 10, 2016
eugeneia
added a commit
to eugeneia/snabb
that referenced
this pull request
Jun 10, 2016
|
Closing in favor of #931. |
dpino
added a commit
to dpino/snabb
that referenced
this pull request
Mar 10, 2017
nh_fwd cache refresh packets need entropy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the shared memory path (shm.path) to a private namespace for each app with prefix "app/$name".
This means that apps can create shm objects such as counters and by default these will appear in a local namespace for that app.
Example (for an app update that will be submitted separately):