I/O statistics counters for Tap/RawSocket apps #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the shared memory path (shm.path) to a private namespace for each app with prefix "app/$name". This means that apps can create shm objects such as counters and by default these will appear in a local namespace for that app.
- Use "apps/" instead of "app/" for uniformity - Set shm path to "apps/$name" when calling `app:stop' too - Unlink "apps/$name" after `app:stop' using `shm.unlink' - Add a test case to core.app selftest
# Conflicts: # src/core/app.lua
…eric representation.
option and support injecting a function to determine the current time.
This reverts commit 8bb3215.
# Conflicts: # src/core/counter.lua
This reverts commit 924ff4e.
This reverts commit e9f5dda.
# Conflicts: # src/apps/intel/intel10g.lua # src/core/app.lua
| self.tdt = band(self.tdt + 1, num_descriptors - 1) | ||
| end | ||
| self.txdesc[self.tdt].address = memory.virtual_to_physical(p.data) | ||
| self.txdesc[self.tdt].options = bor(p.length, txdesc_flags, lshift(p.length+0ULL, 46)) |
There was a problem hiding this comment.
In future patches, I'd like comments or defined constants explaining numbers like that 46.
|
This has merge conflicts with the packet documentation in README.md. Once those are fixed, I'm happy to merge this. |
…dicate." Reason: its actually slower than the initial naive version. This reverts commit c186591. # Conflicts: # src/apps/vhost/vhost_user.lua
# Conflicts: # src/apps/vhost/vhost_user.lua # src/lib/protocol/README.md
|
@kbara merge conflicts with which branch, |
|
It has merge conflicts with kbara-next, due to the documentation patch that you also wrote (on packet structure) and which has been upstreamed. I'll resolve the conflict if you'd prefer not to. |
kbara
pushed a commit
to kbara/snabb
that referenced
this pull request
Jul 4, 2016
Fixed packet documentation merge conflict
lukego
added a commit
that referenced
this pull request
Jul 11, 2016
dpino
added a commit
to dpino/snabb
that referenced
this pull request
Sep 19, 2017
Decouple alarms declaration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #931. Coverage of Solarflare and Intel1G apps is coming in a separate PR (waiting for Solarflare test hardware and completion of #897).
Besides adding statistics counters[1] to the Tap and RawSocket apps, this also adds counting of broadcast packets to vhost_user.
1:
provided_counters = { 'type', 'dtime', 'rxbytes', 'rxpackets', 'rxmcast', 'rxbcast', 'txbytes', 'txpackets', 'txmcast', 'txbcast' }