-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove requirement for handshake dependencies #296
Comments
Hey, thanks. I think it's totally possible, but might result in too many |
Precisely. It feels wrong to include unused code, especially whole dependencies. Increases compile time and attack vectors. But I do understand if you'd prefer not to add additional |
Got it. If it does not change the code-readability much, I would be totally ok with it :) |
Nice! Then I'll send a PR to this repo and to tokio-tungstenite this weekend. Thanks! |
@application-developer-DA I've sent the PRs :) |
Hey @Icelk , is it currently possible to make a WebSocket instance with skipping the handshake? In my case, I'm also handling the handshake manually, but can't figure out how to use this library without the handshake. EDIT: Nevermind! I just found |
Hi. Thanks for the great code!
Is it possible for you to add a cargo feature for the handshake code? I'm handling the handshake manually, so the dependencies pulled in (like
httparse
) are unnecessary.I can make a PR if you'd like. Thanks!
The text was updated successfully, but these errors were encountered: